NetworkWatcher: Added new parameters to QueryConnectionMonitorResult and ConnectivityCheckRequest by irrogozh · Pull Request #2763 · Azure/azure-rest-api-specs

irrogozh · 2018-03-28T18:22:30Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…and ConnectivityCheckRequest

AutorestCI · 2018-03-28T18:31:44Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#22

AutorestCI · 2018-03-28T18:41:01Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-03-28T18:51:53Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-03-28T19:09:35Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2610

salameer · 2018-03-29T17:13:23Z

Hi @irrogozh

@MikhailTryakhov we neel to Ack on CHanges for Networking that are against master, please follow up with him

=Thanks,

Samer

MikhailTryakhov · 2018-03-29T20:22:05Z

specification/network/resource-manager/Microsoft.Network/stable/2018-02-01/networkWatcher.json

+    "ProtocolConfiguration": {
+      "description": "Configuration of the protocol.",
+      "properties": {
+        "hTTPConfiguration": {


is hTTP case expected?

MikhailTryakhov · 2018-03-29T20:45:49Z

@salameer As I can see there are no breaking changes, it need to be merged ASAP to make it GA :)
@irrogozh could you please make minor fixes to use similar case for option names and we can escalate merging

MikhailTryakhov · 2018-03-29T21:41:09Z

LGTM
@anuchandy could you please review?

olydis · 2018-03-30T17:37:37Z

specification/network/resource-manager/Microsoft.Network/stable/2018-02-01/networkWatcher.json

          ],
          "x-ms-enum": {
-            "name": "Protocol",
+            "name": "IpFlowProtocol",


breaking change 1

olydis · 2018-03-30T17:38:14Z

specification/network/resource-manager/Microsoft.Network/stable/2018-02-01/networkWatcher.json

    },
    "ConnectionMonitorQueryResult": {
      "properties": {
+        "sourceStatus": {


breaking change 2 (constructor signature)

olydis · 2018-03-30T17:39:25Z

@MikhailTryakhov @salameer FYI, there are SDK breaking changes (see my comments) but indeed no API breakage.
@MikhailTryakhov do you require review from @anuchandy?

olydis

LGTM

MikhailTryakhov · 2018-03-30T21:24:20Z

@olydis I meant no API breakage. I needed Anu because have no rights to approve :) now it can be merged

olydis · 2018-03-30T21:53:42Z

@MikhailTryakhov well, all reviewers (like me) have the power to merge, so whoever is assigned to a PR will be the POC 🙂

irrogozh added 7 commits February 15, 2018 17:58

Updated examples for network watcher

a71c92f

Updated api version in network watcher swagger and examples

534e121

Fixed Linter errors

1fb0844

Fixed Linter errors: iteration 2

6a2b7a0

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

a0cdb78

NetworkWatcher: Added new parameters to QueryConnectionMonitorResult …

21568d4

…and ConnectivityCheckRequest

NetworkWatcher: Fixed typo

e374ea2

irrogozh requested a review from DeepakRajendranMsft as a code owner March 28, 2018 18:22

azuresdkci assigned anuchandy Mar 28, 2018

azuresdkci requested a review from anuchandy March 28, 2018 18:23

AutorestCI mentioned this pull request Mar 28, 2018

[AutoPR network/resource-manager] NetworkWatcher: Added new parameters to QueryConnectionMonitorResult and ConnectivityCheckRequest AutorestCI/azure-libraries-for-java#21

Merged

AutorestCI mentioned this pull request Mar 28, 2018

[AutoPR network/resource-manager] NetworkWatcher: Added new parameters to QueryConnectionMonitorResult and ConnectivityCheckRequest Azure/azure-sdk-for-node#2578

Closed

anuchandy added the Reassign label Mar 29, 2018

azuresdkci removed the Reassign label Mar 29, 2018

azuresdkci assigned olydis and unassigned anuchandy Mar 29, 2018

azuresdkci requested a review from olydis March 29, 2018 00:33

MikhailTryakhov reviewed Mar 29, 2018

View reviewed changes

Fixed casing for HTTPConfiguration property

72acce7

olydis reviewed Mar 30, 2018

View reviewed changes

olydis approved these changes Mar 30, 2018

View reviewed changes

olydis added the potential-sdk-breaking-change label Mar 30, 2018

olydis merged commit 576abc9 into Azure:master Mar 30, 2018

iscai-msft pushed a commit that referenced this pull request Jul 9, 2021

Update ManagedIdentity.json (#2763)

a135b0d

jordan13game referenced this pull request in test-repo-billy/azure-rest-api-specs Apr 26, 2022

Update ManagedIdentity.json (#2763)

570d7f5

dw511214992 referenced this pull request in dw511214992/azure-rest-api-specs Jul 8, 2022

Update ManagedIdentity.json (test-repo-billy#2763)

5af42f9

dw511214992 referenced this pull request in test-repo-billy/azure-rest-api-specs Oct 27, 2022

Update ManagedIdentity.json (#2763)

7b86a6a

Conversation

irrogozh commented Mar 28, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

salameer commented Mar 29, 2018

Uh oh!

MikhailTryakhov Mar 29, 2018

Choose a reason for hiding this comment

Uh oh!

irrogozh Mar 29, 2018

Choose a reason for hiding this comment

Uh oh!

MikhailTryakhov commented Mar 29, 2018

Uh oh!

MikhailTryakhov commented Mar 29, 2018

Uh oh!

olydis Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

olydis Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

olydis commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

MikhailTryakhov commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olydis commented Mar 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

irrogozh commented Mar 28, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 28, 2018 •

edited

Loading

AutorestCI commented Mar 28, 2018 •

edited

Loading

AutorestCI commented Mar 28, 2018 •

edited

Loading

AutorestCI commented Mar 28, 2018 •

edited

Loading

olydis commented Mar 30, 2018 •

edited

Loading

MikhailTryakhov commented Mar 30, 2018 •

edited

Loading